refactor: small changes

modules/profiles/base.nix

@@ -34,17 +34,29 @@ let
 
   which-nix = pkgs.writeFishApplication {
     name = "which-nix";
-    runtimeInputs = with pkgs; [ which coreutils-full ];
+    runtimeInputs = with pkgs; [ which coreutils-full procps ];
     text = /* fish */ ''
-      readlink -f (which $argv)
+      function recurse -a path;
+        if not test -f "$path"
+          return
+        end
+
+        echo $path
+        if test -L $path
+          recurse (readlink $path)
+        end
+      end
+      
+      for arg in $argv
+        recurse (which $arg)
+      end
     '';
     completions = /* fish */ ''
       complete -c which-nix -fa '(__fish_complete_command)'
     '';
   };
 
-  gi = pkgs.writeFishApplication
+  gi = pkgs.writeFishApplication {
-    {
     name = "gi";
     runtimeInputs = with pkgs; [ fzf gum curl ];
     text = /* fish */ ''

modules/programs/fish.nix

@@ -8,9 +8,12 @@ with lib;
 let
   cfg = config.my.programs.fish;
   shellConfig = config.my.shell;
+  exportedVariables =
+    let
       exportVariables =
         lib.mapAttrsToList (n: v: ''set -x ${n} "${v}"'') shellConfig.variables;
-  exportedVariables = lib.concatStringsSep "\n" exportVariables;
+    in
+    lib.concatStringsSep "\n" exportVariables;
 in
 {
   options.my.programs.fish.enable = mkEnableOption "fish";

modules/services/openconnect.nix

@@ -17,7 +17,7 @@ in
         gateway = "vpn.uni-leipzig.de";
         protocol = "anyconnect";
         user = "mb18cele@uni-leipzig.de";
-        # NOTE file content as follows:
+        # NOTE: file content as follows:
         # <my_password>
         # "1-Standard-Uni" or "2-Spezial-Alles"
         # Explanation:

overlays/builders.nix

@@ -2,16 +2,14 @@ _:
 
 final: _:
 with final.lib;
-{
+rec {
-  writeFishApplication =
+  fishFile =
     { name
-    , text
+    , destination
-    , completions ? null
+    , content
-    , runtimeInputs ? [ ]
     , checkPhase ? null
     }:
-    let
+    final.writeTextFile {
-      fishFile = destination: content: final.writeTextFile {
       inherit name destination;
       executable = true;
       allowSubstitutes = true;
@@ -19,8 +17,6 @@ with final.lib;
       text = ''
         #!${getExe final.fish}
 
-          ${optionalString (runtimeInputs != [ ]) ''export PATH="${makeBinPath runtimeInputs}:$PATH"''}
-
         ${content}
       '';
 
@@ -33,8 +29,29 @@ with final.lib;
         else checkPhase;
     };
 
-      script = fishFile "/bin/${name}" text;
+  writeFishApplication =
-      completions_file = fishFile "/share/fish/vendor_completions.d/${name}.fish" completions;
+    { name
+    , text
+    , completions ? null
+    , runtimeInputs ? [ ]
+    , checkPhase ? null
+    }:
+    let
+      runtimeHeader = optionalString (runtimeInputs != [ ])
+        ''export PATH="${makeBinPath runtimeInputs}:$PATH"'';
+
+      script = fishFile {
+        inherit checkPhase;
+        name = "${name}_script";
+        destination = "/bin/${name}";
+        content = concatLines [ runtimeHeader text ];
+      };
+      completions_file = fishFile {
+        inherit checkPhase;
+        name = "${name}_completions";
+        destination = "/share/fish/vendor_completions.d/${name}.fish";
+        content = concatLines [ runtimeHeader completions ];
+      };
     in
     final.symlinkJoin {
       inherit name;